Adds rejectRateLimitedCalls option for WebClient #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
=========================================
+ Coverage 88.23% 88.54% +0.3%
=========================================
Files 7 7
Lines 408 419 +11
Branches 70 72 +2
=========================================
+ Hits 360 371 +11
Misses 31 31
Partials 17 17
Continue to review full report at Codecov.
|
medoror
added a commit
to medoror/slackstats
that referenced
this pull request
Jul 27, 2020
* Rate limiting is still weird. Look at this for more information: slackapi/node-slack-sdk#599 slackapi/node-slack-sdk#669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a feature for users who choose to handle rate-limited requests on their own.
By setting
rejectRateLimitedCallstotrue, any time the Slack Web API response with a status code 429, theWebClient#apiCall()method's returned Promise will reject (or callback will invoke) with an error. That error is a new error type, denoted by thecodeproperty, which is equal to theErrorCode.RateLimitedErrorvalue (another top-level export).Builds upon #596
Fixes #451
TODO
Requirements (place an
xin each[ ])